Ignore NotFound errors when deleting GCE resources

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters

Apache License 2.0

377 stars 68 forks source link

Closed nicksardo closed 6 years ago

nicksardo commented 6 years ago

Following up on https://github.com/kubernetes/kubernetes/issues/54717, the GCE wrapper functions will no longer capture and ignore NotFound errors. As I mentioned in https://github.com/kubernetes/kubernetes/pull/54746#issuecomment-352911385, it seems that the only callers missing this check are in this repo. Recommend auditing all resource deletion calls prior to updating your vendor.

Ping me if you're too busy for this and I'll shoot you a PR.

cc @bowei

G-Harmon commented 6 years ago

cc me.

nikhiljindal commented 6 years ago

Hey @nicksardo Thanks for filing this.

Would love to have your first kubemci PR :)

G-Harmon commented 6 years ago

Nikhil, I said that we (I) could do this.

nikhiljindal commented 6 years ago

Cool

nikhiljindal commented 6 years ago