search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Making --gcp-project optional by extracting project from gcloud #138

Closed nikhiljindal closed 6 years ago

nikhiljindal commented 6 years ago

Fixes https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/80

cc @csbell @madhusudancs @G-Harmon

nikhiljindal commented 6 years ago

Fixed the test and verified that the e2e test still passes!

nikhiljindal commented 6 years ago

Thanks for the review @madhusudancs Updated code as per comments. PTAL

madhusudancs commented 6 years ago

/lgtm