search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Ignore "HTTP not found" errors when deleting GCP resources. #140

Closed G-Harmon closed 6 years ago

G-Harmon commented 6 years ago

ingress-gce recently changed to uniformly return "not found" errors (instead of sometimes masking them). This change is needed before revendoring ingress-gce. Fixes issue #119

cc @Nicksardo @csbell @nikhiljindal

This change is Reviewable

k8s-ci-robot commented 6 years ago

Hi @G-Harmon. Thanks for your PR.

I'm waiting for a kubernetes or GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nikhiljindal commented 6 years ago

/ok-to-test

nikhiljindal commented 6 years ago

Thanks for sending this @G-Harmon Added a comment

G-Harmon commented 6 years ago

PTAL. I've updated all the resources to log whether it was Not Found or not.

nikhiljindal commented 6 years ago

Thanks for the fixes. Merging!