Closed nikhiljindal closed 6 years ago
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
CLAs look good, thanks!
Had pushed the commit with wrong author :) Fixed it now
Thanks for the review @G-Harmon Updated code as per comments.
Also updated ingress-gce documentation to ensure that it has instructions for both pre-shared cert annotation and secret: https://github.com/kubernetes/ingress-gce/pull/144
cc @prameshj as FYI
Adding documentation for HTTPS ingresses
cc @csbell @G-Harmon