search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Adding documentation for HTTPS #143

Closed nikhiljindal closed 6 years ago

nikhiljindal commented 6 years ago

Adding documentation for HTTPS ingresses

cc @csbell @G-Harmon

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot commented 6 years ago

CLAs look good, thanks!

nikhiljindal commented 6 years ago

Had pushed the commit with wrong author :) Fixed it now

nikhiljindal commented 6 years ago

Thanks for the review @G-Harmon Updated code as per comments.

Also updated ingress-gce documentation to ensure that it has instructions for both pre-shared cert annotation and secret: https://github.com/kubernetes/ingress-gce/pull/144

nikhiljindal commented 6 years ago

cc @prameshj as FYI