Closed nikhiljindal closed 6 years ago
Will rebase this once https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/150 and #151 merge.
/assign
Thanks for the review @madhusudancs Updated code as per comments. Have pushed a different commit for latest changes.
The new commit also has some changes to FakeForwardingRuleSyncer to fix TestRemoveFromClusters in loadbalancersyncer_test.go due to rebasing on https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/146
Thanks for the review @madhusudancs Updated code as per comments. Also squashed commits
Will merge once the tests pass
Ref https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/145
Main changes:
We wont need special migration for existing MCI's. Gradually as users update their MCI, status will be migrated from forwarding rule to urlmap.
User visible change: If they run
kubemci create
again with existing ingress spec, they will expect it to not make any change. With this, it will throw an error saying user needs to run the command with--force
to update the forwarding rule and urlmap. Will include it in release notes.cc @csbell @G-Harmon