GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Updating latest depencies #150

Closed nikhiljindal closed 6 years ago

nikhiljindal commented 6 years ago

First commit auto generated by running glide update --strip-vendor.

Had to clear cache as per @G-Harmon's suggestion: https://github.com/Masterminds/glide/issues/592#issuecomment-344769706

Also removed the kubernetes pin that was added in https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/93

Second commit is to fix the build using latest dependencies (renames and code moves). It has following changes that were required to fix the build:

Trigger for getting latest change: https://github.com/kubernetes/ingress-gce/pull/169, https://github.com/kubernetes/ingress-gce/pull/165.

cc @G-Harmon @csbell @madhusudancs

nikhiljindal commented 6 years ago

Verified that go run test/e2e/e2e.go is still green with these changes :)

@madhusudancs Will be great if you can take a look since I am not sure if @csbell and @G-Harmon will get to.

nikhiljindal commented 6 years ago

To add more context, the second commit has following changes that were required to fix the build:

These are all due to changes to ingress-gce code that we are using.

madhusudancs commented 6 years ago

Thanks for the clarification. It would be great if you can copy that comment to your original PR description and/or the second commit so others who might have to bisect the commits get better visibility.

madhusudancs commented 6 years ago

/lgtm

nikhiljindal commented 6 years ago

Sure updated the PR description as well. Thanks!