Closed nikhiljindal closed 6 years ago
Verified that go run test/e2e/e2e.go
is still green with these changes :)
@madhusudancs Will be great if you can take a look since I am not sure if @csbell and @G-Harmon will get to.
To add more context, the second commit has following changes that were required to fix the build:
[]*ForwardingRule
instead of ForwardingRuleList
pkg/annotations
instead of utils
.annotations.FromIngress(ing)
instead of annotations.IngAnnotations(ing.ObjectMeta.Annotations)
(similar change for services)These are all due to changes to ingress-gce code that we are using.
Thanks for the clarification. It would be great if you can copy that comment to your original PR description and/or the second commit so others who might have to bisect the commits get better visibility.
/lgtm
Sure updated the PR description as well. Thanks!
First commit auto generated by running
glide update --strip-vendor
.Had to clear cache as per @G-Harmon's suggestion: https://github.com/Masterminds/glide/issues/592#issuecomment-344769706
Also removed the kubernetes pin that was added in https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/93
Second commit is to fix the build using latest dependencies (renames and code moves). It has following changes that were required to fix the build:
Trigger for getting latest change: https://github.com/kubernetes/ingress-gce/pull/169, https://github.com/kubernetes/ingress-gce/pull/165.
cc @G-Harmon @csbell @madhusudancs