Closed nikhiljindal closed 6 years ago
I'll take a look at this one.
Thanks for the review @perotinus Pushed a new commit as per comments. PTAL. Will squash commits after lgtm before merging.
Rebased to remove merge conflicts and fixed test. @perotinus PTAL
/lgtm
Thanks for the review @perotinus
Updated as per comments and squashed commits. Will merge once tests pass
Ref https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/58 (remove-clusters) and https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/145 (storing status on url map instead of forwarding rule).
Follow up to https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/146 which added a
kubemci remove-clusters
command. That PR updated the status stored on forwarding rule. This PR updates that code to update the status on url map as well.The status could be stored on forwarding rule (for old MCIs) or url map (for new MCIs).
cc @G-Harmon @csbell @madhusudancs