search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Update remove-clusters to remove clusters from urlmaps status as well #151

Closed nikhiljindal closed 6 years ago

nikhiljindal commented 6 years ago

Ref https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/58 (remove-clusters) and https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/145 (storing status on url map instead of forwarding rule).

Follow up to https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/146 which added a kubemci remove-clusters command. That PR updated the status stored on forwarding rule. This PR updates that code to update the status on url map as well.

The status could be stored on forwarding rule (for old MCIs) or url map (for new MCIs).

cc @G-Harmon @csbell @madhusudancs

perotinus commented 6 years ago

I'll take a look at this one.

nikhiljindal commented 6 years ago

Thanks for the review @perotinus Pushed a new commit as per comments. PTAL. Will squash commits after lgtm before merging.

nikhiljindal commented 6 years ago

Rebased to remove merge conflicts and fixed test. @perotinus PTAL

perotinus commented 6 years ago

/lgtm

nikhiljindal commented 6 years ago

Thanks for the review @perotinus

Updated as per comments and squashed commits. Will merge once tests pass