search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Adding tests for validating remove-clusters command flags #152

Closed nikhiljindal closed 6 years ago

nikhiljindal commented 6 years ago

Follow up to https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/146.

Adding tests to verify flags are validated as expected. This is similar to tests for other commands.

cc @csbell @G-Harmon @perotinus

nikhiljindal commented 6 years ago

@perotinus Can you please review this one?

perotinus commented 6 years ago

/lgtm unless you want to modify to table-based tests.

nikhiljindal commented 6 years ago

Thanks @perotinus Updated as per comments