Running kubemci delete when mci does not exist is failing - Githubissues

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters

Apache License 2.0

376 stars 68 forks source link

Running kubemci delete when mci does not exist is failing #155

Closed nikhiljindal closed 6 years ago

nikhiljindal commented 6 years ago

Looking at the logs for https://k8s-testgrid.appspot.com/sig-multicluster-kubemci#kubemci-ingress-conformance, I see kubemci delete is failing with: error in deleting target HTTPS proxy mci1-tps--echomap: googleapi: Error 404: The resource 'projects/k8s-ingress-boskos-16/global/targetHttpsProxies/mci1-tps--echomap' was not found

This is due to a typo in code: https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/blob/master/app/kubemci/pkg/gcp/targetproxy/targetproxysyncer.go#L96.

We didnt catch it in out unit tests because our fake never returns NotFound: https://github.com/kubernetes/ingress-gce/blob/f5c87b1611ed3034b5cc795f63b7bcb8915c7365/pkg/loadbalancers/fakes.go#L298.

Steps to fix:

Fix the typo
Update the fakes in ingress-gce to return NotFound

cc @G-Harmon

nikhiljindal commented 6 years ago

Realized there is a 3rd step as well to fetch the latest code from ingress-gce :) Sent https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/157 for that. The first 2 are done