Fixing targetproxy deletion to not return an error when it does not exist

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters

Apache License 2.0

376 stars 68 forks source link

Fixing targetproxy deletion to not return an error when it does not exist #156

Closed nikhiljindal closed 6 years ago

nikhiljindal commented 6 years ago

Ref https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/155

Also added tests to ensure that we do not regress. The tests wont fail however, until we update the ingress-gce fakes to return NotFound as expected (details in issue)

cc @G-Harmon @csbell

G-Harmon commented 6 years ago

/LGTM, assuming tests pass. Feel free to merge when test comes back green.