Closed ahmetb closed 6 years ago
Yes we auto infer gcp-project from gcloud: https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/80.
But turns out that we did it only for kubemci create
and kubemci delete
.
We need to do it for kubemci list
and kubemci get-status
as well.
cc @G-Harmon You can take this up since you are planning to add missing TestValidateGetStatusWithGCPProject
and TestValidateListWithGCPProject
tests.
We do not plan to rename gcp-project at this time.
Got it.
Once we add it to list/get-status, I strongly recommend removing it from the tutorials.
Fixed with #172 and #176.
low-pri; not beta blocker.
Consider inferring gcp project from
gcloud config get-value core/project
. Most other tools built on gcloud does this (while still providing a --flag to customize).Consider renaming --gcp-project to --project unless there's plans to support other cloud providers. This makes it consistent across other GCP tools, like gcloud.