search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

examples/zone-printer: Rewrite instructions #163

Closed ahmetb closed 6 years ago

ahmetb commented 6 years ago

I rewrote the tutorial to make it follow our conventions and tone. It may seem a bit more boring and robotic, but I think this makes it easier to follow.

I renamed clusters to cluster-1 and cluster-2, and got rid of the asia-* one.

Also some simplifications around the kubeconfig file names and reduced the amount of information people need to know about the kubeconfig files in general so I added .yaml extension to these files.

Also added command outputs to some of the commands listed, to give an idea of what it would look like.

I am planning on simplifying the "how does it work?" part by rewriting the sample without using nginx (because nginx is often confused as it is a load balancer itself).

/cc @nikhiljindal @g-harmon

Signed-off-by: Ahmet Alp Balkan ahmetb@google.com

ahmetb commented 6 years ago

This needs updating after merging #165. But let's merge this first, then I'll apply the updates.

ahmetb commented 6 years ago

Addressed the code review feedback. This now accommodates the GCE clusters that are not GKE.

ahmetb commented 6 years ago

Addressed code review feedback, thanks @G-Harmon.

ahmetb commented 6 years ago

@nikhiljindal all set! Let's merge this and the sample, I assume there will be a lot of things to change. I'll have to execute the tutorial again to correct the file paths and instructions.

nikhiljindal commented 6 years ago

Thanks for the fixes @ahmetb Can you please squash commits and I will then merge this.

ahmetb commented 6 years ago

FYI you have an option to squash commits yourself (next to the Merge button)

ahmetb commented 6 years ago

but I just squashed FWIW