Check gcloud for project, and add unit tests.

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters

Apache License 2.0

376 stars 68 forks source link

Closed G-Harmon closed 6 years ago

G-Harmon commented 6 years ago

Adds missing functionality for getting GCP Project from gcloud settings, and adds unit tests for this.

cc @nikhiljindal

This change is

nikhiljindal commented 6 years ago

Looks great, One comment about updating flag description to clarify its optional. Also xref https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/138 for easy referencing :)

G-Harmon commented 6 years ago

This is part of fixing #80

nikhiljindal commented 6 years ago

/lgtm thx for the fixes

nikhiljindal commented 6 years ago

will merge once tests come back green