search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

IngressSyncer: Fix a bug in DeleteIngress and add more unit tests. #174

Closed G-Harmon closed 6 years ago

G-Harmon commented 6 years ago

Please ignore the first commit (server version validation), it's open PR #167 .

It seemed like the tests were already in pretty good shape for DeleteIngress. I added 2 more cases, and uncovered/fixed one small bug.

cc @csbell @nikhiljindal

This change is Reviewable

nikhiljindal commented 6 years ago

/lgtm Thanks. Once #167 merges, you can rebase and merge this.