search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Move all validation to create.go and add more unit testing. #183

Closed G-Harmon closed 6 years ago

G-Harmon commented 6 years ago

-Creates an interface for Validations and a fake Validator for unit tests. -Adds a unit test for create.go:createIngressAndLoadBalancer.

cc @nikhiljindal @csbell

This change is Reviewable

k8s-ci-robot commented 6 years ago

@G-Harmon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-multicluster-ingress-test db268a3eb1719ef09c796e28652725c86632f224 link /test pull-kubernetes-multicluster-ingress-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).