search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Make gofmt check return an error, and check more .go files. #184

Closed G-Harmon closed 6 years ago

G-Harmon commented 6 years ago

In order for gofmt to be blocking, we have to wrap it in a script that checks for a non-empty return. In the process, I switched from using "go list" [dirs with _test.go files] to using all .go files that aren't in /vendor.

cc @madhusudancs @nikhiljindal

This change is Reviewable

nikhiljindal commented 6 years ago

Awesome @G-Harmon Thanks!

/lgtm

nikhiljindal commented 6 years ago

Great, lgtm. Feel free to merge when tests pass