search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Make lint errors blocking, and fix a few last lint problems #186

Closed G-Harmon closed 6 years ago

G-Harmon commented 6 years ago

This adds a wrapper script to error-out if there are lint problems. This only checks packages with _test.go files. We could extend it to all .go files in the code base (but there are a few more lint errors to fix).

Another commit fixes up 2 existing lint errors.

This change is Reviewable

k8s-ci-robot commented 6 years ago

@G-Harmon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-multicluster-ingress-test 943162e95b4366c8edf5aa7f6bc9fe82cb2eaca8 link /test pull-kubernetes-multicluster-ingress-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
nikhiljindal commented 6 years ago

/lgtm