search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Removing go get golint since the test image now has golint #187

Closed nikhiljindal closed 6 years ago

nikhiljindal commented 6 years ago

Ref https://github.com/kubernetes/test-infra/pull/7604

cc @G-Harmon

nikhiljindal commented 6 years ago

Lets see if the test passes :)

nikhiljindal commented 6 years ago

/test pull-kubernetes-multicluster-ingress-test Couldnt find logs for the failure. Retrying

nikhiljindal commented 6 years ago

Cant get details again. Its failing with Unable to load build details. Looking at https://k8s-gubernator.appspot.com/builds/kubernetes-jenkins/pr-logs/pull/GoogleCloudPlatform_k8s-multicluster-ingress/, I cant get any of the links to work for past runs.

cc @BenTheElder @krzyzacy Any ideas why?

BenTheElder commented 6 years ago

you should check prow.k8s.io, logs won't upload if your job can't execute or something along those l ines

/retest

G-Harmon commented 6 years ago

/lgtm but the test still isn't uploading logs...

G-Harmon commented 6 years ago

golint failed- couldn't find golint. vet failed- W0406 23:53:56.097] app/kubemci/pkg/gcp/forwardingrule/forwardingrulesyncer_test.go:240: github.com/GoogleCloudPlatform/k8s-multicluster-ingress/app/kubemci/pkg/gcp/status.LoadBalancerStatus composite literal uses unkeyed fields

krzyzacy commented 6 years ago

/retest

krzyzacy commented 6 years ago

?! no pod logs? /retest

k8s-ci-robot commented 6 years ago

@nikhiljindal: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-multicluster-ingress-test bc5492702fdf116eff5be8281d4c76221d3f1caa link /test pull-kubernetes-multicluster-ingress-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
krzyzacy commented 6 years ago 
NAME                                   READY     STATUS               RESTARTS   AGE
2efee4b9-39f9-11e8-9931-0a580a6c031a   0/1       ContainerCannotRun   0          4m

whoops

BenTheElder commented 6 years ago

sen: this isn't going to work. discussed a better route offline with @nikhiljindal

On Fri, Apr 6, 2018 at 5:20 PM k8s-ci-robot notifications@github.com wrote:

@nikhiljindal https://github.com/nikhiljindal: The following test failed, say /retest to rerun them all: Test name Commit Details Rerun command pull-kubernetes-multicluster-ingress-test bc54927 https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/commit/bc5492702fdf116eff5be8281d4c76221d3f1caa link https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/GoogleCloudPlatform_k8s-multicluster-ingress/187/pull-kubernetes-multicluster-ingress-test/235/ /test pull-kubernetes-multicluster-ingress-test

Full PR test history https://k8s-gubernator.appspot.com/pr/GoogleCloudPlatform_k8s-multicluster-ingress/187. Your PR dashboard https://k8s-gubernator.appspot.com/pr/nikhiljindal. Please help us cut down on flakes by linking to https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests an open issue https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues?q=is:issue+is:open when you hit one in your PR.

Instructions for interacting with me using PR comments are available here https://git.k8s.io/community/contributors/devel/pull-requests.md. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue: repository. I understand the commands that are listed here https://go.k8s.io/bot-commands.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/187#issuecomment-379417478, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4BqyADeU6iPAf27letFGtX8yuERPF5ks5tmAZJgaJpZM4TKzbc .

nikhiljindal commented 6 years ago

https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/189 is the better route.