search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
377 stars 68 forks source link

Switch from glide to Go Modules (go 1.11+) #219

Closed hermanbanken closed 4 years ago

hermanbanken commented 5 years ago

Glide did not seem to pick up the specified versions in the lock file anymore. Could be an incompatibility introduced lately or something else, I don't know.

So what I did was copy the glide.lock file to the go.mod file, made it compatible with go.mod and ran go mod vendor to fix the module file (replaces the git SHA with the full version, eg. v0.1.1-0.20160913182117-3b1ae45394a2).

NB: Go Modules will exclude subpackages from the vendor directory that are unused, so there are quite a few deletions below.

k8s-ci-robot commented 5 years ago

Hi @hermanbanken. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.