GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Support multiple pre-shared-certs. #230

Open oceanful opened 4 years ago

oceanful commented 4 years ago

Adds support for multiple pre-shared certificates in Ingress and Load balancer.

This addresses https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/120 for pre-shared ssl certificates, but not for secret ssl certificates; the latter would require updating to a version of the kubernetes/ingress-gce library that returns multiple TLSCerts from TLSCertsFromSecretsLoader.Load().

A known issue is that updates to the pre-shared certificates in the Ingress definition will not propagate to changes to the Load balancer: https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/141. Addressing this would also require updating to a newer version of the Google Compute API to leverage TargetHttpsProxiesService.SetSslCertificates().

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

k8s-ci-robot commented 4 years ago

Hi @oceanful. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
oceanful commented 4 years ago

@googlebot I signed it!

On Fri, Oct 25, 2019 at 11:20 AM googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA Individual signers

Corporate signers

ℹ️ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2FGoogleCloudPlatform%2Fk8s-multicluster-ingress%2Fpull%2F230 for more info.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/230?email_source=notifications&email_token=AISJD2RXQPTF7HEZTX3BSP3QQM2H5A5CNFSM4JFG7SN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECJE7WA#issuecomment-546459608, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISJD2T4O4SMPZVBAU4FJI3QQM2H5ANCNFSM4JFG7SNQ .

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

oceanful commented 4 years ago

@nikhiljindal is there anything I need to do to move this forward?