Open oceanful opened 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Hi @oceanful. Thanks for your PR.
I'm waiting for a GoogleCloudPlatform or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@googlebot I signed it!
On Fri, Oct 25, 2019 at 11:20 AM googlebot notifications@github.com wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version https://opensource.google.com/docs/cla/#troubleshoot).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
- The email used to register you as an authorized contributor must also be attached to your GitHub account https://github.com/settings/emails.
ℹ️ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2FGoogleCloudPlatform%2Fk8s-multicluster-ingress%2Fpull%2F230 for more info.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/230?email_source=notifications&email_token=AISJD2RXQPTF7HEZTX3BSP3QQM2H5A5CNFSM4JFG7SN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECJE7WA#issuecomment-546459608, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISJD2T4O4SMPZVBAU4FJI3QQM2H5ANCNFSM4JFG7SNQ .
@nikhiljindal is there anything I need to do to move this forward?
Adds support for multiple pre-shared certificates in Ingress and Load balancer.
This addresses https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/120 for pre-shared ssl certificates, but not for secret ssl certificates; the latter would require updating to a version of the kubernetes/ingress-gce library that returns multiple TLSCerts from
TLSCertsFromSecretsLoader.Load()
.A known issue is that updates to the pre-shared certificates in the Ingress definition will not propagate to changes to the Load balancer: https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/141. Addressing this would also require updating to a newer version of the Google Compute API to leverage
TargetHttpsProxiesService.SetSslCertificates()
.