search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
376 stars 68 forks source link

Update zoneprinter code to include more functionality #235

Closed rramkumar1 closed 4 years ago

rramkumar1 commented 4 years ago

New functionality includes:

  1. Configurable health check path + port
  2. ability to kill health checks (i.e simulate health check failures)
  3. Configurable version to simulate deployment upgrades.
  4. root path which dumps useful information including version

Note that these changes introduce no new dependencies.

This change is Reviewable

rramkumar1 commented 4 years ago

/assign @ahmetb

rramkumar1 commented 4 years ago

/assign @nikhiljindal

ahmetb commented 4 years ago

Please make sure you also run gofmt, I also notice a compilation error in handlefunc for /.

rramkumar1 commented 4 years ago

@ahmetb Should be fixed now.

nikhiljindal commented 4 years ago

lgtm

Will wait for @ahmetb's lgtm before merging.

ahmetb commented 4 years ago

/lgtm