search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
377 stars 68 forks source link

Future-proof Health Check comparison for healthchecksyncer.go. #55

Closed G-Harmon closed 6 years ago

G-Harmon commented 6 years ago

Instead of checking for fields we explicitly care about, we switch to a blacklist of fields that we ignore. This way, future fields are automatically considered.

Also adds some more logging in error cases.

cc @nikhiljindal @csbell @madhusudancs

This change is Reviewable

nikhiljindal commented 6 years ago

Thanks Greg. This looks great modulo one comment about using fmt.Printf() instead of glog.Infof() throughout this PR.

G-Harmon commented 6 years ago

okay, fixed up. PTAL.

nikhiljindal commented 6 years ago

Thanks. As discussed glog.Infof and glog.Warningf are fine since they dont show up on screen by default. Users can use them if they want more debug information in which case, printing the file and line number make sense.

nikhiljindal commented 6 years ago

lgtm. thanks!