search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
377 stars 68 forks source link

Adding a Makefile #62

Closed nikhiljindal closed 6 years ago

nikhiljindal commented 6 years ago

Adding a Makefile with standard rules.

Makefile inspired from https://github.com/kubernetes/ingress-nginx/blob/b68feb9c590e2c11bdb098549f3208f80029daf7/Makefile

cc @csbell @G-Harmon @madhusudancs @perotinus

madhusudancs commented 6 years ago

/lgtm

nikhiljindal commented 6 years ago

Found out that go fmt, lint and vet are failing. Filed #59, #60 and #61.

Also found out that our current unit test coverage is ~50-60%. (least is 39% and max is 90%). Details: https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/48#issuecomment-343065547

nikhiljindal commented 6 years ago

Thanks @perotinus Updated as per comments

nikhiljindal commented 6 years ago

Merging so that /test all starts to work once https://github.com/kubernetes/test-infra/pull/5373 is merged.