search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
377 stars 68 forks source link

Add Coverage widget to Readme. #64

Closed G-Harmon closed 6 years ago

G-Harmon commented 6 years ago

cc @nikhiljindal @csbell @madhusudancs

This change is Reviewable

k8s-ci-robot commented 6 years ago

Hi @G-Harmon. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nikhiljindal commented 6 years ago

/ok-to-test

This is awesome, @G-Harmon love it!

k8s-ci-robot commented 6 years ago

@G-Harmon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-multicluster-ingress-test 9a790747697d53625b8c41fc40da62f8d0a07ab3 link /test pull-kubernetes-multicluster-ingress-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).
nikhiljindal commented 6 years ago

From the logs:

I1114 21:34:33.940] Call:  /workspace/./test-infra/jenkins/../scenarios/execute.py make -j 2 test coveralls
W1114 21:34:33.963] usage: execute.py [-h] [--env ENV] cmd [args [args ...]]
W1114 21:34:33.963] execute.py: error: unrecognized arguments: -j 2 test coveralls
E1114 21:34:33.964] Command failed

cc @G-Harmon @BenTheElder xref https://github.com/kubernetes/test-infra/pull/5462

BenTheElder commented 6 years ago

Agh, @krzyzacy why is execute scenario parsing args? :(

krzyzacy commented 6 years ago

maybe do make -- -j foo bar?