search

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters
Apache License 2.0
377 stars 68 forks source link

Fixing the coveralls missing repotoken problem #66

Closed G-Harmon closed 6 years ago

G-Harmon commented 6 years ago

I mainly want to run the tests against this PR, and probably not check it in.

cc @nikhiljindal @BenTheElder

This change is Reviewable

k8s-ci-robot commented 6 years ago

Hi @G-Harmon. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nikhiljindal commented 6 years ago

/ok-to-test

G-Harmon commented 6 years ago

Okay, I think we figured out the problem (described in the commit msg now). PTAL.

G-Harmon commented 6 years ago

/retest

nikhiljindal commented 6 years ago

/lgtm Will merge once tests pass

G-Harmon commented 6 years ago

okay, looks like coveralls succeeded! (https://coveralls.io/builds/14221758) Unfortunately, I haven't seen Coveralls post coverage data back to this PR. anyway, I think this is ready to merge.