Handle update targetproxy for non-urlmap link changes

GoogleCloudPlatform / k8s-multicluster-ingress

kubemci: Command line tool to configure L7 load balancers using multiple kubernetes clusters

Apache License 2.0

377 stars 68 forks source link

Handle update targetproxy for non-urlmap link changes #94

Open nikhiljindal opened 6 years ago

nikhiljindal commented 6 years ago

@G-Harmon rightly pointed out in https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/92 that we do not handle the situation when the difference in existing and desired target proxies is something other than the urlmap link (for ex description).

We assume that if they differ, it must be the urlmap link and hence update that only. We need to fix this.

hjkatz commented 5 years ago

What's the status of this issue? We're running into problems trying to update SSL certs for these target proxies while using the ingress.gcp.kubernetes.io/pre-shared-cert annotation in our Ingress.

I see that there are methods for updating this SSL cert for the target https proxy in the vendored ingress-gce code and I wonder if that could be added into this specific method?