GoogleCloudPlatform / k8s-stackdriver

Apache License 2.0
391 stars 212 forks source link

Documentation bugs in custom-metrics-stackdriver-adapter README #583

Open asfaltboy opened 12 months ago

asfaltboy commented 12 months ago

I'm just starting to follow the Custom Metrics - Stackdriver Adapter installation instructions (got here from the GKE doc on 'Optimize Pod autoscaling based on metrics'), and already noticing a few odd issues with the docs:

Given the warning in the root of the repo, are contributions welcome? Also, is it even recommended to follow this guide, or is there a way to install the adapter automatically in GKE?

PaulRudin commented 10 months ago

... in particular in the section about workload identity. Presumably you need to create the GCP service account - but this isn't made explicit.

CatherineF-dev commented 9 months ago

Given the warning in the root of the repo, are contributions welcome?

Yes, contributions are welcomed @asfaltboy

You can create a PR, and we will help review.

CatherineF-dev commented 9 months ago

/label custom-metrics-stackdriver-adapter