GoogleCloudPlatform / k8s-stackdriver

Apache License 2.0
391 stars 213 forks source link

Fix vulnerabilities by upgrading dependencies #690

Closed CatherineF-dev closed 6 months ago

CatherineF-dev commented 6 months ago

/hold

CatherineF-dev commented 6 months ago

Have some unit test failures, will update test codes.

CatherineF-dev commented 6 months ago

/retest

CatherineF-dev commented 6 months ago

/retest

CatherineF-dev commented 6 months ago

/hold

Need to wait another dependency fix. https://github.com/kubernetes-sigs/custom-metrics-apiserver/pull/171

CatherineF-dev commented 6 months ago

Tested locally, got error

F0425 18:58:49.422639       1 openapi.go:43] Failed to build open api spec for root: cannot find model definition for k8s.io/metrics/pkg/apis/custom_metrics/v1beta1.MetricValueList. If you added a new type, you may need to add +k8s:openapi-gen=true to the package or type and run code-gen again
CatherineF-dev commented 6 months ago

Tested it can work.

Annotations:                <none>
Namespace:                  default
Labels:                     <none>
Annotations:                <none>
CreationTimestamp:          Mon, 29 Apr 2024 17:31:33 +0000
Reference:                  Deployment/custom-metric-sd
Metrics:                    ( current / target )
  "custom-metric" on pods:  40 / 20
Min replicas:               1
Max replicas:               5
Deployment pods:            2 current / 2 desired
Conditions:
  Type            Status  Reason              Message
  ----            ------  ------              -------
  AbleToScale     True    ReadyForNewScale    recommended size matches current size
  ScalingActive   True    ValidMetricFound    the HPA was able to successfully calculate a replica count from pods metric custom-metric
  ScalingLimited  False   DesiredWithinRange  the desired count is within the acceptable range
Events:           <none>
CatherineF-dev commented 6 months ago

Discussed offline, leonzz has LGTMed. Will merge.