search

GoogleCloudPlatform / kube-jenkins-imager

Apache License 2.0
258 stars 82 forks source link

Added prepare.sh script and cluster configuration files #6

Closed tdeheurles closed 8 years ago

tdeheurles commented 9 years ago

Hi, this pull request add to small parts :

  1. A cluster.cfg configuration file to remove parameters from the cluster_up.sh script.
    The idea is to be able to continue to pull the main repository and have the configuration stay at home. Like it is for the secrets
  2. A very simple prepare.sh script that copy the templates to the gitignored files (cluster.cfg and ssl_secrets.yaml)
evandbrown commented 9 years ago

Very nice! Pulling the config out makes a lot of sense. We should probably just combine the existing images.cfg into your new cluster.cfg file and have all of this in one place. So one file named cluster.cfg. If that sounds OK, mind updating the PR? I also had one minor suggestion for the text I added as a comment for README.md.

tdeheurles commented 9 years ago

Yes, was in the scope but I doesn't want to make to much changes. I try to finish that in the week-end.

tdeheurles commented 8 years ago

I don't have so much time for that for now. Maybe we can close the PR for now ?