search

GoogleCloudPlatform / kubeflow-distribution

Blueprints for Deploying Kubeflow on Google Cloud Platform and Anthos
Apache License 2.0
77 stars 63 forks source link

[usability] services should not be managed by config connector #202

Open Bobgy opened 3 years ago

Bobgy commented 3 years ago

Background

For convenience, we defined required services for each package as config connector resources. Example: https://github.com/kubeflow/gcp-blueprints/blob/master/packages/management/cluster/enable-services.yaml. Also, we deploy them using config connector or gcloud beta anthos apply.

Problem

In https://www.kubeflow.org/docs/gke/deploy/delete-cli/#deleting-your-kubeflow-cluster,

make delete-gcp will also delete all the service entries. However, services typically should have a different life cycle than Kubeflow clusters.

This makes it harder to use the same management cluster for multiple Kubeflow clusters.

Proposal

Enable services via explicit gcloud commands and let users manage disabling a service by themselves.

Bobgy commented 3 years ago

/cc @zijianjoy

zijianjoy commented 3 years ago

Thank you for flagging this issue! May I ask what will be broken if user removes gcpservice https://cloud.google.com/config-connector/docs/reference/resource-docs/serviceusage/service?

My guess is that management cluster cannot create/delete certain GCP resources of the kubeflow project. But existing Kubeflow cluster's GCP resources are still running.

We might need to move the gcpservice to management/ package, so user only needs to run once for each Kubeflow project.