search

GoogleCloudPlatform / kubeflow-distribution

Blueprints for Deploying Kubeflow on Google Cloud Platform and Anthos
Apache License 2.0
80 stars 63 forks source link

(profile-controller) Adopt v1.3.0-gcp profile controller #262

Closed zijianjoy closed 3 years ago

zijianjoy commented 3 years ago

This is our current way to adopting https://github.com/kubeflow/kubeflow/pull/5761/files.

I am able to create profile and add contributor via UI and yaml file.

Note that even though I have added sidecar injection label istio.io/rev=asm-192-2 to kubeflow namespace. I am not able to inject sidecar for KFP yet. It might not be related to this PR.

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/gcp-blueprints/blob/master/OWNERS)~~ [Bobgy,zijianjoy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment