(chore) Address comment for PR #279

GoogleCloudPlatform / kubeflow-distribution

Blueprints for Deploying Kubeflow on Google Cloud Platform and Anthos

Apache License 2.0

80 stars 63 forks source link

(chore) Address comment for PR #279 #280

Closed zijianjoy closed 3 years ago

zijianjoy commented 3 years ago

Address my own comments: https://github.com/kubeflow/gcp-blueprints/pull/279

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/gcp-blueprints/blob/master/OWNERS)~~ [zijianjoy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

zijianjoy commented 3 years ago

Merging it for RC.0 for now, and welcome for comment.

Bobgy commented 3 years ago

/lgtm /approve