Closed zijianjoy closed 3 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: zijianjoy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm /hold Feel free to unhold
New changes are detected. LGTM label has been removed.
/unhold
Thank you Yuan! Remaining TODOs need to wait for upstream fixes. Merging while waiting for fixes.
Partial #308
Steps of deployment:
List of changes:
v1alpha1
tov1
. Existence of Kptfile marks a sub-package.# {"$kpt-set":"foo"}
comments to# kpt-set: ${foo}
in yaml files.env.sh
to be set inkpt-setter-config.yaml
.kpt-set.sh
to apply kpt values. Usesapply-setters
mutator for high level directories (apps, common, contrib)kpt-setter-config.yaml
instead ofKptfile
.asm
folder out ofcommon
to avoid apply-setters.TODO:
[ ] pull-upstream.sh in kubeflow/ level and pipelines/ level are pulling from zijianjoy. We need to change to actual upstream while waiting for kpt release. https://github.com/kubeflow/pipelines/issues/6100
[x] krmignore needs to be broken down to per component krmignore file after fixing https://github.com/GoogleContainerTools/kpt/issues/2506.
[ ] Update documentation for deployment and asm upgrade, and kpt version requirement.
[ ] Update asm Makefile to use
kpt pkg get
for downloading config package, after https://github.com/GoogleCloudPlatform/anthos-service-mesh-packages/issues/964 is fixed.