GoogleCloudPlatform / kubeflow-distribution

Blueprints for Deploying Kubeflow on Google Cloud Platform and Anthos
Apache License 2.0
78 stars 63 forks source link

Use KptFile and not settings.yaml file to read back in setters #39

Open jlewi opened 4 years ago

jlewi commented 4 years ago

Right now our Makefile uses a bit of a hack to get back the values of various kpt setters. We set them in https://github.com/kubeflow/gcp-blueprints/blob/master/kubeflow/instance/settings.yaml using kpt setters and then read them back in.

But the KptFile is also a YAML file. If we use substitutions do the values get stored there and can we read them from it?

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.61

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

subodh101 commented 3 years ago

This issue is resolved and can be closed

cc: @jlewi

issue-label-bot[bot] commented 3 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
platform/gcp 0.99

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

jlewi commented 3 years ago

Woo Hoo; Thanks @subodh101

jlewi commented 3 years ago

Sorry; Just realized we will need to update the docs.

kubeflow/website#2126

issue-label-bot[bot] commented 3 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
area/docs 0.80

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.