search

GoogleCloudPlatform / kubernetes-engine-windows-tools

Apache License 2.0
4 stars 11 forks source link

Fix a bug where windows builder would always try to reuse the builders #23

Closed barp closed 10 months ago

barp commented 10 months ago

but would delete them at the end because of incorrect value check for reuse builders parameter.

In addition Change the Expand-Archive to a faster .net ExpandToDirectory function and shorten the name of the workspace folder in order to allow for more space for long paths.

barp commented 10 months ago

@ibabou Can you review, YangLu1031 is no longer on this team.

ibabou commented 10 months ago

@ibabou Can you review, YangLu1031 is no longer on this team.

Hey Bar, thanks for the contribution! I'll plan to take a look at the change.

danaradg commented 10 months ago

Hi @ibabou, do you have an estimate of how long will it take to review and merge this?

ibabou commented 10 months ago

Hi @ibabou, do you have an estimate of how long will it take to review and merge this?

Thanks again Bar for the changes, it LGTM. I'll go ahead and merge the changes.