search

GoogleCloudPlatform / localllm

Apache License 2.0
1.49k stars 113 forks source link

Update setup.py #14

Closed The-User-Python closed 4 months ago

The-User-Python commented 4 months ago

In this code, I've made minor formatting improvements for better readability and adherence to PEP 8 style guidelines. The script now uses #!/usr/bin/env python to make it more portable, and the license comment has been adjusted to provide a valid link to the Apache License.

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

bobcatfish commented 4 months ago

Hi @The-User-Python ! I like the change to use #!/usr/bin/env python but it looks this PR also makes a change to the license header, which afaik we want to keep consistent across google projects (and as far as I can tell, the part this PR removes is part of the standard license header for Apache 2.0), so we'd need to remove that part of the PR.

I'm going to close this PR for now but feel free to open more! (and to change #!/usr/bin/env python in other files also!) And if you do want to open more PRs, FYI you'll need to sign the google CLA as well which you can see in one of the failed chcks above ^^