GoogleCloudPlatform / localllm

Apache License 2.0
1.49k stars 113 forks source link

fix: model name should be set #27

Open RealHurrison opened 2 months ago

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

bobcatfish commented 2 months ago

Interesting, I'm not sure that the string being used as the model name will make sense to the chat completion API - and the endpoint afaik would only be hosting one model anyway 🤔 I'm curious what will happen when this is set though

im also wondering if we could remove that argument entirely instead

bobcatfish commented 2 months ago

/gcbrun