search

GoogleCloudPlatform / marketplace-k8s-app-example

Apache License 2.0
24 stars 19 forks source link

Deployer should fail if env variables don't exist #12

Closed huyhg closed 6 years ago

huyhg commented 6 years ago

...or if the $() command fails (this should already be working, but it should be good to double check).

Some applications want to include ${VARIABLE} literally in the manifest. These have to be escaped, but sometimes the template creator makes mistakes. This feature will help with catching these--of course it can't catch the case where VARIABLE is also a valid env variable in the deployer.

trironkk commented 6 years ago

Unassigned - I'll reassign to me when I start work.

huyhg commented 6 years ago

Related to #51

huyhg commented 6 years ago

Closing this in favor of #51.