search

GoogleCloudPlatform / marketplace-k8s-app-example

Apache License 2.0
23 stars 19 forks source link

Adding custom parameters to k8s-app. #62

Closed trironkk closed 6 years ago

trironkk commented 6 years ago

This pull request purely illustrative, to give config UI development data to test against.

These new parameters are unused at deployer time and runtime.

trironkk commented 6 years ago

Clarified intention in base first comment (pasting below):

This pull request purely illustrative, to give config UI development data to test against.

These new parameters are unused at deployer time and runtime.

huyhg commented 6 years ago

@vcanaa Can you look into why the integration test is not being triggered?

huyhg commented 6 years ago

Ah, I think it's because the branch is currently missing cloudbuild.yaml--cloudbuild triggered builds are failing because of this. Pulling in changes from master should fix it.