Helm example wordpress mariadb

GoogleCloudPlatform / marketplace-k8s-app-example

Apache License 2.0

23 stars 19 forks source link

Helm example wordpress mariadb #75

Closed khajduczenia closed 4 years ago

khajduczenia commented 6 years ago

This PR relies on two PR from the tools repository:

GoogleCloudPlatform/marketplace-k8s-app-tools#110 - filtering out the Helm tests during the app deployment
GoogleCloudPlatform/marketplace-k8s-app-tools#111 - ensuring that K8s Apps labels are present in all resources deployed as part of the application

huyhg commented 6 years ago

LGTM at quick glance.

I will leave this to @vcanaa for complete reviewing. The idea here is that we're gonna replace the current nginx example with this one to demonstrate (1) helm template with dependencies and (2) helm tests.

Vini, we'll need to update this with your recent changes in terms of helm test supporting.

huyhg commented 6 years ago

I think we should add a README to detail what changes we made when we imported the community Wordpress helm chart.

huyhg commented 6 years ago

Can we also update cloudbuild to make sure that this is passing integration tests? :)