search

GoogleCloudPlatform / metacontroller

Lightweight Kubernetes controllers as a service
https://metacontroller.app/
Apache License 2.0
792 stars 105 forks source link

Delete namespace resource from kustomize #129

Closed mgoodness closed 5 years ago

mgoodness commented 5 years ago

Would like to use these manifests as a base for kustomize, but with my own namespace and not have the metacontroller namespace created. Shouldn't be necessary anyway, as most (all?) other tools will create the namespace automatically for the other resources.

enisoc commented 5 years ago

When I try kubectl apply -f manifests/metacontroller-rbac.yaml with your patch and kubectl v1.11.3, it fails to create the ServiceAccount with error namespaces "metacontroller" not found.

Is there another way to make the metacontroller namespace optional when used as a kustomize base, but still include it by default when using these manifests directly with kubectl apply?

mgoodness commented 5 years ago

Oops, you're right. Not sure what I was thinking.

We could pull the namespace out into its own manifests/namespace.yaml file and not include that in kustomization.yaml. Then one could run kubectl apply -f manifests/ and get the desired effect while excluding it from kustomize.

googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

mgoodness commented 5 years ago

Oops again. Closing and will resubmit. Sorry.