Full implementation of the customize hook

Kritzefitz commented 5 years ago

Implementation of https://metacontroller.app/design/customize-hook/

This is based on the rebased branch from #143.

Closes: #98

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Kritzefitz commented 5 years ago

I signed it!

googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

Kritzefitz commented 5 years ago

The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

That's probably @mikebryant's commit. Would you confirm that it may be included in this PR?

mikebryant commented 5 years ago

Yup, fine by me :)

mikebryant commented 5 years ago

@enisoc This seems to have stalled, would someone be able to help from the google side?

luisdavim commented 5 years ago

any updates here?

Kritzefitz commented 4 years ago

Just to be sure: Is there something I still need to do, before this can be merged? From my point of view this can be reviewed and merged, but apparently that's not happening.

luisdavim commented 4 years ago

the probem is https://github.com/GoogleCloudPlatform/metacontroller/issues/184. Also Google didn't recognised that you've signed the CLA.

grzesuav commented 4 years ago

@Kritzefitz hi, what about moving it forward ?

grzesuav commented 4 years ago

or maybe it would be suitable to make this change against https://github.com/AmitKumarDas/metac ?

Kritzefitz commented 4 years ago

@grzesuav I would really like to move this forward, but as @luisdavim already mentioned, the future of the maintenance of metacontroller is currently discussed in #184. I'm afraid this merge request (or others) won't be merged until a solution for the future maintenance is found.

I guess re-targeting the changes from this PR against metac would make the changes available there sooner, than waiting for the maintenance situation of metacontroller to get resolved would. However, I currently don't really have the time to port the changes over to another project and I'm still hoping that #184 will come to a reasonable conclusion for the maintanance of metacontroller.

However, if you like, you may of course feel free to try to port the changes to metac yourself.

luisdavim commented 4 years ago

@grzesuav it's probably better if you open this against the metac fork.

grzesuav commented 4 years ago

@Kritzefitz thanks for explanation :). When I was posting this message I wasn't aware that there is some process in progress. Unfortunately I do not now go-lang therefore not sure I can create PR against forked repo. Will try but not sure if they aren't any discrepancies.

AmitKumarDas commented 4 years ago

There is a similar implementation in Metac by the name GenericController.

References:

GoogleCloudPlatform / metacontroller