GoogleCloudPlatform / metacontroller

Lightweight Kubernetes controllers as a service
https://metacontroller.app/
Apache License 2.0
792 stars 111 forks source link

Warn when /status subresource is not enabled #176

Open mgruener opened 5 years ago

mgruener commented 5 years ago

Metacontroller assumes that a parent resource always has the /status subresource enabled, which it is not by default (at least for CRDs). As Metacontroller also always adds the .status.observedGeneration field, this leads to a hot-loop where adding the .status.observedGeneration field leads to an increment of the .metadata.generation field.

It would be nice when Metacontroller either logs an error when the /status subresource is disabled for a parent resource or does not add the .status.observedGeneration field in this case.