PersistentVolume with external storage support for in-cluster databases

GoogleCloudPlatform / microservices-demo

Sample cloud-first application with 10 microservices showcasing Kubernetes, Istio, and gRPC.

https://cymbal-shops.retail.cymbal.dev

Apache License 2.0

16.65k stars 7.08k forks source link

PersistentVolume with external storage support for in-cluster databases #1231

Open mathieu-benoit opened 1 year ago

mathieu-benoit commented 1 year ago

Today, the in-cluster redis database is a Deployment, as a best practice for such in-cluster scenario it would be great to have it as StatefulSet with a PersistentVolume. Maybe with Filestore like illustrated here? Or maybe another storage? That will also illustrate yet another great story with multiple Google Cloud services while showing best practices. This will allow Online Boutique's users (Googlers, etc.) to have a ready to use solution for such stateful workloads scenarios.

We maybe don't want to have this as default, and we may want to keep this as Deployment by default (?), but maybe to start with a new Online Boutique variation (i.e. Kustomize overlay) would be a great candidate?

Tagging @bourgeoisor @ahrarmonsur @charlieyu1996 as I'm sure they could provide more insights around this and maybe planning this for 2023?

NimJay commented 1 year ago

This is a great idea, and a good point of collaboration for myself and the GKE DPEs.

My initial thoughts:

Should Redis be used here or should we use another database (e.g., MySQL or PostgreSQL) that's more commonly tied to StatefulSets? More specifically, how common is it to tie a StatefulSet to Redis?
Yes, as @mathieu-benoit suggested, I don't think StatefulSets should be used by Online Boutique's default deployment. To ensure Online Boutique is easier to use in demos/tutorials, let's keep it as stateless as possible (by default). For instance, this makes multi-cluster demos easier.
I image we would just be introducing a new Kustomize Component inside /kustomize/components that contains a StatefulSet and related resources (similar to Bank of Anthos).
I've assigned a low priority (P3) to this for now.

bourgeoisor commented 1 year ago

Linking the analogue for Bank of Anthos: https://github.com/GoogleCloudPlatform/bank-of-anthos/issues/1068

NimJay commented 10 months ago

Commenting since this is near out-of-SLO:

Leaving this open since this would be a nice-to-have.
But not a team priority today — keeping at p3.

Irene-123 commented 1 month ago

Can I take this up?