search

GoogleCloudPlatform / microservices-demo

Sample cloud-first application with 10 microservices showcasing Kubernetes, Istio, and gRPC.
https://cymbal-shops.retail.cymbal.dev
Apache License 2.0
16.19k stars 6.8k forks source link

"redis-cart" not found in pull-request CI #1246

Closed NimJay closed 1 year ago

NimJay commented 1 year ago

Describe the bug

Pull-requests with error

NimJay commented 1 year ago

More specifically, the following line is failing:

https://github.com/GoogleCloudPlatform/microservices-demo/blob/release/v0.4.1/.github/workflows/ci-pr.yaml#L94

NimJay commented 1 year ago

I'm looking at the namespaces (inside the online-boutique-prs GKE cluster) for 3 of the affected pull-requests. In each PR, only the loadgenerator is running as a workload. I suspect this is related to skaffold.

Screen Shot 2022-11-07 at 10 59 55 AM

NimJay commented 1 year ago

I suspect that the online-boutique-prs GKE cluster might be overworked. I had to manually remove Online Boutique Deployments (and other K8s resources) from namespaces of pull-requests that have been closed/merged:

kubectl delete all --all -n pr1009 # From a merged PR
kubectl delete all --all -n pr1020 # From a closed PR
kubectl delete all --all -n pr1058 # From a closed PR
kubectl delete all --all -n pr716 # From a closed PR

I wonder if this was the cause of the problem.

NimJay commented 1 year ago

This has been fixed in https://github.com/GoogleCloudPlatform/microservices-demo/pull/1247.