GoogleCloudPlatform / microservices-demo

Sample cloud-first application with 10 microservices showcasing Kubernetes, Istio, and gRPC.
https://cymbal-shops.retail.cymbal.dev
Apache License 2.0
17.09k stars 7.35k forks source link

Remove the "missing version" warnings in istio. #2757

Closed philippehenin closed 1 week ago

philippehenin commented 1 month ago

Write down your inquiry

I used your great “microservices-demo” to show Istio maps and functionalities.

I had warnings on "missing version" in the label app for the file release/kubernetes-manifests.yaml :

As an example, I added this

metadata:
  name: productcatalogservice
  labels:
    app: productcatalogservice
    version: "1"

There is the complete “corrected” file.

Please have no hesitation to close if not relevant.

https://github.com/user-attachments/files/17217269/kubernetes-manifests.yaml.txt

bourgeoisor commented 1 month ago

Hi @philippehenin! Where did you see the warnings? Was it from doing a kubectl apply command? Do you have those logs you could provide?

philippehenin commented 1 month ago

Screenshot 2024-10-03 162628 vs Screenshot 2024-10-03 162940

I know it is not a terrifying improvement, but looks cleaner and gives less change to ask silly questions during a presentation.

By the way, thanks again for publishing this great example.

Have a pleasant day, P.

philippehenin commented 1 week ago

Solved on last version.