search

GoogleCloudPlatform / microservices-demo

Sample cloud-first application with 10 microservices showcasing Kubernetes, Istio, and gRPC.
https://cymbal-shops.retail.cymbal.dev
Apache License 2.0
16.18k stars 6.79k forks source link

Remove use of `latest` tag #696

Closed NimJay closed 1 year ago

NimJay commented 2 years ago

Background

Task

bourgeoisor commented 1 year ago

We'd need to also make sure we're not breaking any existing deployment that uses latest (in a post-log4j-cve-world of course). I think we should still do this but would like to chat about it a bit.

mahi072 commented 1 year ago

Hi, I would like to work on this issue.

vaishnavi-ramanujapuram commented 1 year ago

Hi @NimJay , I have gone through this repository and would like to work on this issue. Do I just need to remove the latest tag and wherever there's a use of latest tag ?

NimJay commented 1 year ago

@vaishnavi-ramanujapuram, I believe you can remove these 3 lines completely:

        # tag as latest
        skaffold build --default-repo=gcr.io/$PROJECT_ID \
                       --tag=latest

from /.github/workflows/push-deploy.yaml.

I don't think those images are used by anyone, anywhere.

If someone wants to use Online Boutique container images, they should use images with explicit versioning (for instance, adservice:v0.4.2 — not adservice:latest).

We should keep the 3 lines above it though:

        # tag with git hash
        skaffold build --default-repo=gcr.io/$PROJECT_ID \
                       --tag=$GITHUB_SHA

so that we're testing the skaffold build-ing of each Online Boutique service, per commit made to the main branch.

Hope this helps. :)

vaishnavi-ramanujapuram commented 1 year ago

Thank you @NimJay , i'll make the changes and submit the PR.

vaishnavi-ramanujapuram commented 1 year ago

@NimJay , i've raised the PR. Please review it and let me know if I need to make any changes. Remove latest tag #1394

vaishnavi-ramanujapuram commented 1 year ago

Also, could you please assign me this as it is part of my academics.

vaishnavi-ramanujapuram commented 1 year ago

@NimJay Thank you for merging my PR. Can you please let me know when this issue will be closed.

NimJay commented 1 year ago

Sorry for the late response, @vaishnavi-ramanujapuram! But thanks again for https://github.com/GoogleCloudPlatform/microservices-demo/pull/1394. I will now close this GitHub Issue.