search

GoogleCloudPlatform / microservices-demo

Sample cloud-first application with 10 microservices showcasing Kubernetes, Istio, and gRPC.
https://cymbal-shops.retail.cymbal.dev
Apache License 2.0
16.77k stars 7.17k forks source link

Run Microservices Demo on Cloud Run #831

Closed cc4i closed 1 year ago

cc4i commented 2 years ago

Describe request or inquiry

The Microservices Demo should able to run on top of Cloud Run with somewhat changes. Redis would be based on Memory Store.

What purpose/environment will this feature serve?

Leverage Microservices Demo to demonstrates the power of Serverless.

cc4i commented 2 years ago

Already done some jobs around that, I'd like to contribute with a proper PR if accept the request.

NimJay commented 2 years ago

This is related to https://github.com/GoogleCloudPlatform/microservices-demo/pull/652.

NimJay commented 2 years ago

@grayside do you think https://github.com/GoogleCloudPlatform/cloud-run-samples is a better place for Cloud Run samples using microservices-demo (Online Boutique)?

The reason I ask: this (microservices-demo) repo is owned by the Anthos/GKE DPE team — and I worry about the Cloud-Run-related maintenance cost that the Anthos/GKE DPE team would have to deal with.

@cc4i, a few questions for you: :)

  1. Have you considered using a separate repository?
  2. Would you prefer to have the Cloud Run samples live in this repo? Is so, why?
  3. Have you talked to a Cloud Run tech writer (about turning your samples into a cloud.google.com tutorial)? If not, I think it'd be a cool idea (after you've merged the samples into some public repo of course).
cc4i commented 2 years ago

@NimJay Thanks for pointing out. Idea was came from a PoC, maybe Cloud Run is good place to go if the repo is specific for Anthos/GKE.

mathieu-benoit commented 2 years ago

Hi @NimJay, what do we want to do with this one? Closing and maybe documenting on the main README.md where end users can find the branches/repos with the support of Cloud Run?

NimJay commented 2 years ago

@mathieu-benoit that sounds like a good compromise for now.

Aside for Googlers that would like to contribute medium-large changes to this repository: please see this Google Doc.

mathieu-benoit commented 1 year ago

Thanks @michaelact, @xiangshen-dk and @cc4i for your contributions. Like discussed, even if having Online Boutique on Cloud Run is a very good idea, we want to keep this repository specific to Kubernetes for now.

If anyone is interested in this, here are some implementations made about that for reference: