search

GoogleCloudPlatform / ml-design-patterns

Source code accompanying O'Reilly book: Machine Learning Design Patterns
Apache License 2.0
1.9k stars 533 forks source link

Chapter 2 embeddings last cell - change request #22

Open jeromemassot opened 3 years ago

jeromemassot commented 3 years ago

Dear authors,

The last cell of the notebook could be confusing : indeed, when using pre-trained embedding vectors, it is not useful to have EMBED_DIM parameter defined. The build_hub_model() method does not use it hopefully :)

Best regards Jerome