search

GoogleCloudPlatform / netd

netd: GKE Networking Daemonset
Apache License 2.0
54 stars 41 forks source link

Increase the timeout for cilium-healthy to 10m. #259

Closed Ramkumar-K closed 9 months ago

Ramkumar-K commented 9 months ago

The earlier behavior of reporting the node as healthy after 1m has led to some customer issues. Increasing the timeout to 10m will help in most cases.

This change also uses an environment variable, so that the value can be modified from the pod-spec.

jingyuanliang commented 9 months ago

/lgtm /approve

google-oss-prow[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyuanliang, Ramkumar-K

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/netd/blob/master/OWNERS)~~ [jingyuanliang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment